[freeside-commits] freeside/FS/FS/part_export globalpops_voip.pm, 1.8.2.1, 1.8.2.2

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS/part_export
In directory wavetail.420.am:/tmp/cvs-serv8588

Modified Files:
      Tag: FREESIDE_2_3_BRANCH
	globalpops_voip.pm 
Log Message:
show a VoIP Innovations login error in the log, RT#15150

Index: globalpops_voip.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/part_export/globalpops_voip.pm,v
retrieving revision 1.8.2.1
retrieving revision 1.8.2.2
diff -u -w -d -r1.8.2.1 -r1.8.2.2
--- globalpops_voip.pm	13 Feb 2012 04:45:21 -0000	1.8.2.1
+++ globalpops_voip.pm	13 Feb 2012 05:06:52 -0000	1.8.2.2
@@ -60,21 +60,23 @@
   }
 
   my $dids = $self->gp_command('getDIDs', %getdids);
+
   if ( $dids->{'type'} eq 'Error' ) {
-    die "Error running VoIP Innovations getDIDs: ".
-        $search->{'statuscode'}. ': '. $search->{'status'}; #die??
+    my $error =  "Error running VoIP Innovations getDIDs: ".
+        $dids->{'statuscode'}. ': '. $dids->{'status'}. "\n";
+    warn $error;
+    die $error;
   }
 
-  #use Data::Dumper;
-  #warn Dumper($dids);
-
   my $search = $dids->{'search'};
 
   if ( $search->{'statuscode'} == 302200 ) {
     return [];
   } elsif ( $search->{'statuscode'} != 100 ) {
-    die "Error running VoIP Innovations getDIDs: ".
-        $search->{'statuscode'}. ': '. $search->{'status'}; #die??
+    my $error = "Error running VoIP Innovations getDIDs: ".
+                 $search->{'statuscode'}. ': '. $search->{'status'}. "\n";
+    warn $error;
+    die $error;
   }
 
   my @return = ();
@@ -246,7 +248,10 @@
   my( $self, $command, @args ) = @_;
 
   eval "use Net::GlobalPOPs::MediaServicesAPI;";
-  die $@ if $@;
+  if ( $@ ) {
+    warn $@;
+    die $@;
+  }
 
   my $gp = Net::GlobalPOPs::MediaServicesAPI->new(
     'login'    => $self->option('login'),