[freeside-commits] branch FREESIDE_2_3_BRANCH updated. d14751b1bf9660a35361d25ed3bb6fc42187fcf4

Ivan ivan at 420.am
Thu Dec 20 19:34:23 PST 2012


The branch, FREESIDE_2_3_BRANCH has been updated
       via  d14751b1bf9660a35361d25ed3bb6fc42187fcf4 (commit)
       via  15f3b67f04275a8dd0b0fde35cd4e350557a2db0 (commit)
      from  63075e170262a1aebd7acd3a1d2a1ef06a84fce9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d14751b1bf9660a35361d25ed3bb6fc42187fcf4
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Dec 20 19:34:06 2012 -0800

    fix tax-on-tax (i.e. FEDERAL UNIVERSAL SERVICE FUND) on 2.3 branch, RT#20707

diff --git a/FS/FS/cust_main/Billing.pm b/FS/FS/cust_main/Billing.pm
index 3837ad2..1487fee 100644
--- a/FS/FS/cust_main/Billing.pm
+++ b/FS/FS/cust_main/Billing.pm
@@ -799,7 +799,7 @@ sub calculate_taxes {
   my %packagemap = map { $_->pkgnum => $_ } @$cust_bill_pkg;
   foreach my $tax ( keys %$taxlisthash ) {
     foreach ( @{ $taxlisthash->{$tax} }[1 .. scalar(@{ $taxlisthash->{$tax}}) - 1] ) {
-      next unless ref($_) eq 'FS::cust_bill_pkg';
+      next unless ref($_) eq 'FS::cust_bill_pkg'; #IS needed for CCH tax-on-tax
 
       my @cust_tax_exempt_pkg = splice( @{ $_->_cust_tax_exempt_pkg } );
 

commit 15f3b67f04275a8dd0b0fde35cd4e350557a2db0
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Dec 20 19:31:49 2012 -0800

    fix tax-on-tax (i.e. FEDERAL UNIVERSAL SERVICE FUND) on 2.3 branch, RT#20707

diff --git a/FS/FS/cust_main/Billing.pm b/FS/FS/cust_main/Billing.pm
index 0fb91ef..3837ad2 100644
--- a/FS/FS/cust_main/Billing.pm
+++ b/FS/FS/cust_main/Billing.pm
@@ -799,7 +799,7 @@ sub calculate_taxes {
   my %packagemap = map { $_->pkgnum => $_ } @$cust_bill_pkg;
   foreach my $tax ( keys %$taxlisthash ) {
     foreach ( @{ $taxlisthash->{$tax} }[1 .. scalar(@{ $taxlisthash->{$tax}}) - 1] ) {
-      #next unless ref($_) eq 'FS::cust_bill_pkg'; #no longer needed
+      next unless ref($_) eq 'FS::cust_bill_pkg';
 
       my @cust_tax_exempt_pkg = splice( @{ $_->_cust_tax_exempt_pkg } );
 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main/Billing.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)




More information about the freeside-commits mailing list