[freeside-commits] branch FREESIDE_2_3_BRANCH updated. 96bb37b68d74110d2875e011baa955d7c55dc892

[Ivan]

The branch, FREESIDE_2_3_BRANCH has been updated
       via  96bb37b68d74110d2875e011baa955d7c55dc892 (commit)
      from  dfb703365f0561bdf5ad01b677eca7a90cda52cf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 96bb37b68d74110d2875e011baa955d7c55dc892
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Dec 20 12:06:15 2012 -0800

    fix "Use of implicit split to @_ is deprecated" warning, RT#20731, RT#20706

diff --git a/FS/FS/part_pkg/voip_cdr.pm b/FS/FS/part_pkg/voip_cdr.pm
index cac5838..73b0aed 100644
--- a/FS/FS/part_pkg/voip_cdr.pm
+++ b/FS/FS/part_pkg/voip_cdr.pm
@@ -925,8 +925,8 @@ sub check_chargable {
 
   return "carrierid NOT IN ( $opt{'use_carrierid'} )"
     if $opt{'use_carrierid'} =~ /\S/
-    && !grep { $cdr->carrierid eq $_ } split(/\s*,\s*/, $opt{'use_carrierid'}) #eq otherwise 0 matches ''
-    && ! $flags{'da_rewrote'};
+    && ! $flags{'da_rewrote'} #why?
+    && !grep { $cdr->carrierid eq $_ } split(/\s*,\s*/, $opt{'use_carrierid'}); #eq otherwise 0 matches ''
 
   # unlike everything else, use_cdrtypenum is applied in FS::svc_x::get_cdrs.
   return "cdrtypenum != $opt{'use_cdrtypenum'}"

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/part_pkg/voip_cdr.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)