[freeside-commits] freeside/FS/FS/cust_main Billing_Realtime.pm, 1.9.2.8, 1.9.2.9

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS/cust_main
In directory wavetail.420.am:/tmp/cvs-serv26633

Modified Files:
      Tag: FREESIDE_2_1_BRANCH
	Billing_Realtime.pm 
Log Message:
removing code that deleted pending payments.  a real wtf.  RT#12662

Index: Billing_Realtime.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/cust_main/Billing_Realtime.pm,v
retrieving revision 1.9.2.8
retrieving revision 1.9.2.9
diff -u -w -d -r1.9.2.8 -r1.9.2.9
--- Billing_Realtime.pm	5 May 2011 23:21:23 -0000	1.9.2.8
+++ Billing_Realtime.pm	11 May 2011 00:49:51 -0000	1.9.2.9
@@ -488,24 +488,6 @@
     'custnum' => $self->custnum,
     'status'  => { op=>'!=', value=>'done' } 
   });
-  # This is a problem.  A self-service third party payment that fails somehow 
-  # can't be retried, EVER, until someone manually clears it.  Totally 
-  # arbitrary fix: if the existing payment is more than two minutes old, 
-  # kill it.  This doesn't limit how long it can take the pending payment 
-  # to complete, only how long it will obstruct new payments.
-  my @still_pending;
-  foreach (@pending) {
-    if ( time - $_->_date > 120 ) {
-      my $error = $_->delete;
-      warn "error deleting stale pending payment ".$_->paypendingnum.": $error"
-        if $error; # not fatal, it will fail anyway
-    }
-    else {
-      push @still_pending, $_;
-    }
-  }
-  @pending = @still_pending;
-
   return "A payment is already being processed for this customer (".
          join(', ', map 'paypendingnum '. $_->paypendingnum, @pending ).
          "); $options{method} transaction aborted."