[freeside-commits] freeside/FS/FS cust_pkg.pm, 1.179.2.20, 1.179.2.21

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail.420.am:/tmp/cvs-serv12876

Modified Files:
      Tag: FREESIDE_2_1_BRANCH
	cust_pkg.pm 
Log Message:
prevent all-too-common mistake of editing package dates manually to have a start date and a setup date, RT#11937

Index: cust_pkg.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/cust_pkg.pm,v
retrieving revision 1.179.2.20
retrieving revision 1.179.2.21
diff -u -w -d -r1.179.2.20 -r1.179.2.21
--- cust_pkg.pm	21 Feb 2011 01:21:44 -0000	1.179.2.20
+++ cust_pkg.pm	10 Mar 2011 09:42:09 -0000	1.179.2.21
@@ -598,6 +598,9 @@
   ;
   return $error if $error;
 
+  return "A package with both start date (future start) and setup date (already started) will never bill"
+    if $self->start_date && $self->setup;
+
   $self->usernum($FS::CurrentUser::CurrentUser->usernum) unless $self->usernum;
 
   if ( $self->dbdef_table->column('manual_flag') ) {