[freeside-commits] freeside/FS/FS Misc.pm,1.33.4.1,1.33.4.2

Ivan,,, ivan at wavetail.420.am
Tue Mar 30 23:30:38 PDT 2010


Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail.420.am:/tmp/cvs-serv11914

Modified Files:
      Tag: FREESIDE_1_9_BRANCH
	Misc.pm 
Log Message:
eliminate harmless "Use of uninitialized value $enc in string eq" warnings

Index: Misc.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/Misc.pm,v
retrieving revision 1.33.4.1
retrieving revision 1.33.4.2
diff -u -w -d -r1.33.4.1 -r1.33.4.2
--- Misc.pm	15 Feb 2010 02:09:29 -0000	1.33.4.1
+++ Misc.pm	31 Mar 2010 06:30:36 -0000	1.33.4.2
@@ -343,14 +343,14 @@
   $smtp_opt{'port'} = $port;
 
   my $transport;
-  if ( $enc eq 'starttls' ) {
+  if ( defined($enc) && $enc eq 'starttls' ) {
     $smtp_opt{$_} = $conf->config("smtp-$_") for qw(username password);
     $transport = Email::Sender::Transport::SMTP::TLS->new( %smtp_opt );
   } else {
     if ( $conf->exists('smtp-username') && $conf->exists('smtp-password') ) {
       $smtp_opt{"sasl_$_"} = $conf->config("smtp-$_") for qw(username password);
     }
-    $smtp_opt{'ssl'} = 1 if $enc eq 'tls';
+    $smtp_opt{'ssl'} = 1 if defined($enc) && $enc eq 'tls';
     $transport = Email::Sender::Transport::SMTP->new( %smtp_opt );
   }
 



More information about the freeside-commits mailing list