[freeside-commits] freeside/FS/FS/ClientAPI Signup.pm, 1.54, 1.55 MyAccount.pm, 1.107, 1.108

[Jeff Finucane,420,,]

Update of /home/cvs/cvsroot/freeside/FS/FS/ClientAPI
In directory wavetail.420.am:/tmp/cvs-serv16637/FS/FS/ClientAPI

Modified Files:
	Signup.pm MyAccount.pm 
Log Message:
eliminate use of 'realtime' arg in calling FS::cust_main_collect RT#4167

Index: MyAccount.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/ClientAPI/MyAccount.pm,v
retrieving revision 1.107
retrieving revision 1.108
diff -u -w -d -r1.107 -r1.108
--- MyAccount.pm	27 Apr 2010 05:38:26 -0000	1.107
+++ MyAccount.pm	13 Jun 2010 05:59:53 -0000	1.108
@@ -1344,7 +1344,7 @@
 
     my $bill_error =    $cust_main->bill
                      || $cust_main->apply_payments_and_credits
-                     || $cust_main->collect('realtime' => 1);
+                     || $cust_main->realtime_collect;
 
     if (    $cust_main->balance > $old_balance
          && $cust_main->balance > 0

Index: Signup.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/ClientAPI/Signup.pm,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -w -d -r1.54 -r1.55
--- Signup.pm	24 Oct 2009 00:34:34 -0000	1.54
+++ Signup.pm	13 Jun 2010 05:59:53 -0000	1.55
@@ -649,14 +649,10 @@
     #     " new customer: $bill_error"
     #  if $bill_error;
 
-    if ($cust_main->_new_bop_required()) {
       $bill_error = $cust_main->realtime_collect(
          method        => FS::payby->payby2bop( $packet->{payby} ),
          depend_jobnum => $placeholder->jobnum,
       );
-    } else {
-      $bill_error = $cust_main->collect('realtime' => 1);
-    }
     #warn "[fs_signup_server] error collecting from new customer: $bill_error"
     #  if $bill_error;