[freeside-commits] freeside/httemplate/view svc_acct.cgi, 1.59.2.2, 1.59.2.3 svc_domain.cgi, 1.31.2.2, 1.31.2.3

Ivan,,, ivan at wavetail.420.am
Sat Feb 20 14:33:12 PST 2010


Update of /home/cvs/cvsroot/freeside/httemplate/view
In directory wavetail.420.am:/tmp/cvs-serv7665/httemplate/view

Modified Files:
      Tag: FREESIDE_1_9_BRANCH
	svc_acct.cgi svc_domain.cgi 
Log Message:
communigate pro provisioning, RT#7083

Index: svc_acct.cgi
===================================================================
RCS file: /home/cvs/cvsroot/freeside/httemplate/view/svc_acct.cgi,v
retrieving revision 1.59.2.2
retrieving revision 1.59.2.3
diff -u -d -r1.59.2.2 -r1.59.2.3
--- svc_acct.cgi	25 Jan 2010 22:17:29 -0000	1.59.2.2
+++ svc_acct.cgi	20 Feb 2010 22:33:10 -0000	1.59.2.3
@@ -14,335 +14,63 @@
   }
   </SCRIPT>
   
-  <% include("/elements/header.html",'Account View', menubar(
+  <% include("/elements/header.html",'View account', menubar(
     "Cancel this (unaudited) account" =>
             "javascript:areyousure(\'${p}misc/cancel-unaudited.cgi?$svcnum\')",
   )) %>
 
 % } 
 
-% if ( $part_svc->part_export_usage ) {
-%
-%  my $last_bill;
-%  my %plandata;
-%  if ( $cust_pkg ) {
-%    #false laziness w/httemplate/edit/part_pkg... this stuff doesn't really
-%    #belong in plan data
-%    %plandata = map { /^(\w+)=(.*)$/; ( $1 => $2 ); }
-%                    split("\n", $cust_pkg->part_pkg->plandata );
-%
-%    $last_bill = $cust_pkg->last_bill;
-%  } else {
-%    $last_bill = 0;
-%    %plandata = ();
-%  }
-%
-%  my $seconds = $svc_acct->seconds_since_sqlradacct( $last_bill, time );
-%  my $hour = int($seconds/3600);
-%  my $min = int( ($seconds%3600) / 60 );
-%  my $sec = $seconds%60;
-%
-%  my $input = $svc_acct->attribute_since_sqlradacct(
-%    $last_bill, time, 'AcctInputOctets'
-%  ) / 1048576;
-%  my $output = $svc_acct->attribute_since_sqlradacct(
-%    $last_bill, time, 'AcctOutputOctets'
-%  ) / 1048576;
-%
-%
-
-
-  RADIUS session information<BR>
-  <% ntable('#cccccc',2) %>
-  <TR><TD BGCOLOR="#ffffff">
-% if ( $seconds ) { 
-
-    Online <B><% $hour %></B>h <B><% $min %></B>m <B><% $sec %></B>s
-% } else { 
-
-    Has not logged on
-% } 
-% if ( $cust_pkg ) { 
-
-    since last bill (<% time2str('%a %b %o %Y', $last_bill) %>)
-% if ( length($plandata{recur_included_hours}) ) { 
-
-    - <% $plandata{recur_included_hours} %> total hours in plan
-% } 
-
-    <BR>
-% } else { 
-
-    (no billing cycle available for unaudited account)<BR>
-% } 
-
-
-  Upload: <B><% sprintf("%.3f", $input) %></B> megabytes<BR>
-  Download: <B><% sprintf("%.3f", $output) %></B> megabytes<BR>
-  Last Login: <B><% $svc_acct->last_login_text %></B><BR>
-% my $href = qq!<A HREF="${p}search/sqlradius.cgi?svcnum=$svcnum!; 
-
-  View session detail:
-      <% $href %>;begin=<% $last_bill %>">this billing cycle</A>
-    | <% $href %>;begin=<% time-15552000 %>">past six months</A>
-    | <% $href %>">all sessions</A>
-
-  </TD></TR></TABLE><BR>
-% } 
-
-% my @part_svc = ();
-% if ($FS::CurrentUser::CurrentUser->access_right('Change customer service')) {
-
-    <SCRIPT TYPE="text/javascript">
-      function enable_change () {
-        if ( document.OneTrueForm.svcpart.selectedIndex > 1 ) {
-          document.OneTrueForm.submit.disabled = false;
-        } else {
-          document.OneTrueForm.submit.disabled = true;
-        }
-      }
-    </SCRIPT>
-
-    <FORM NAME="OneTrueForm" ACTION="<%$p%>edit/process/cust_svc.cgi">
-    <INPUT TYPE="hidden" NAME="svcnum" VALUE="<% $svcnum %>">
-    <INPUT TYPE="hidden" NAME="pkgnum" VALUE="<% $pkgnum %>">
+<% include( 'svc_acct/radius_usage.html',
+              'svc_acct' => $svc_acct,
+              'part_svc' => $part_svc,
+              'cust_pkg' => $cust_pkg,
+              %gopt,
+          )
+%>
 
-%   #print qq!<BR><A HREF="../misc/sendconfig.cgi?$svcnum">Send account information</A>!; 
-% 
-%   if ( $pkgnum ) { 
-%     @part_svc = grep {    $_->svcdb   eq 'svc_acct'
-%                        && $_->svcpart != $part_svc->svcpart }
-%                 $cust_pkg->available_part_svc;
-%   } else {
-%     @part_svc = qsearch('part_svc', {
-%       svcdb    => 'svc_acct',
-%       disabled => '',
-%       svcpart  => { op=>'!=', value=>$part_svc->svcpart },
-%     } );
-%   }
-%
-% }
+<% include( 'svc_acct/change_svc_form.html',
+              'part_svc' => \@part_svc,
+              'svcnum'   => $svcnum,
+              'pkgnum'   => $pkgnum,
+              %gopt,
+          )
+%>
 
 Service #<B><% $svcnum %></B>
 | <A HREF="<%$p%>edit/svc_acct.cgi?<%$svcnum%>">Edit this service</A>
 
-% if ( @part_svc ) { 
-
-| <SELECT NAME="svcpart" onChange="enable_change()">
-    <OPTION VALUE="">Change service</OPTION>
-    <OPTION VALUE="">--------------</OPTION>
-% foreach my $opt_part_svc ( @part_svc ) { 
-
-      <OPTION VALUE="<% $opt_part_svc->svcpart %>"><% $opt_part_svc->svc %></OPTION>
-% } 
-
-  </SELECT>
-  <INPUT NAME="submit" TYPE="submit" VALUE="Change" disabled>
-
-% } 
-
-
-<% &ntable("#cccccc") %><TR><TD><% &ntable("#cccccc",2) %>
-
-<TR>
-  <TD ALIGN="right">Service</TD>
-  <TD BGCOLOR="#ffffff"><% $part_svc->svc %></TD>
-</TR>
-<TR>
-  <TD ALIGN="right">Username</TD>
-  <TD BGCOLOR="#ffffff"><% $svc_acct->username %></TD>
-</TR>
-<TR>
-  <TD ALIGN="right">Domain</TD>
-  <TD BGCOLOR="#ffffff"><% $domain %></TD>
-</TR>
-
-% if ( $svc_acct->pbxsvc ) {
-    <TR>
-      <TD ALIGN="right">PBX</TD>
-      <TD BGCOLOR="#ffffff"><% $svc_acct->pbx_title %></TD>
-    </TR>
-%}
-
-<TR>
-  <TD ALIGN="right">Password</TD>
-  <TD BGCOLOR="#ffffff">
-% my $password = $svc_acct->get_cleartext_password; 
-% if ( $password =~ /^\*\w+\* (.*)$/ ) {
-%         $password = $1;
-%    
-
-      <I>(login disabled)</I>
-% } 
-% if ( !$password and 
-%        $svc_acct->_password_encryption ne 'plain' and
-%        $svc_acct->_password ) {
-      <I>(<% uc($svc_acct->_password_encryption) %> encrypted)</I>
-% }
-% elsif ( $conf->exists('showpasswords') ) { 
-
-      <PRE><% encode_entities($password) %></PRE>
-% } else { 
-
-      <I>(hidden)</I>
-% } 
-
-
-  </TD>
-</TR>
-% $password = ''; 
-% if ( $conf->exists('security_phrase') ) {
-%     my $sec_phrase = $svc_acct->sec_phrase;
-%
-
-  <TR>
-    <TD ALIGN="right">Security phrase</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->sec_phrase %></TD>
-  </TR>
-% } 
-% if ( $svc_acct->popnum ) {
-%    my $svc_acct_pop = qsearchs('svc_acct_pop',{'popnum'=>$svc_acct->popnum});
-%
-
-  <TR>
-    <TD ALIGN="right">Access number</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct_pop->text %></TD>
-  </TR>
-% } 
-% if ($svc_acct->uid ne '') { 
-
-  <TR>
-    <TD ALIGN="right">UID</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->uid %></TD>
-  </TR>
-% } 
-% if ($svc_acct->gid ne '') { 
-
-  <TR>
-    <TD ALIGN="right">GID</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->gid %></TD>
-  </TR>
-% } 
-% if ($svc_acct->finger ne '') { 
-
-  <TR>
-    <TD ALIGN="right">Real Name</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->finger %></TD>
-  </TR>
-% } 
-% if ($svc_acct->dir ne '') { 
-
-  <TR>
-    <TD ALIGN="right">Home directory</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->dir %></TD>
-  </TR>
-% } 
-% if ($svc_acct->shell ne '') { 
-
-  <TR>
-    <TD ALIGN="right">Shell</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->shell %></TD>
-  </TR>
-% } 
-% if ($svc_acct->quota ne '') { 
-
-  <TR>
-    <TD ALIGN="right">Quota</TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->quota %></TD>
-  </TR>
-% } 
-% if ($svc_acct->slipip) { 
-
-  <TR>
-    <TD ALIGN="right">IP address</TD>
-    <TD BGCOLOR="#ffffff">
-      <% ( $svc_acct->slipip eq "0.0.0.0" || $svc_acct->slipip eq '0e0' )
-            ? "<I>(Dynamic)</I>"
-            : $svc_acct->slipip
-      %>
-    </TD>
-  </TR>
-% } 
-% my %ulabel = ( seconds    => 'Time',
-%                upbytes    => 'Upload bytes',
-%                downbytes  => 'Download bytes',
-%                totalbytes => 'Total bytes',
-%              );
-% foreach my $uf ( keys %ulabel ) {
-%   my $tf = $uf . "_threshold";
-%   if ( $svc_acct->$uf ne '' ) {
-%     my $v = $uf eq 'seconds'
-%       #? (($svc_acct->$uf < 0 ? '-' : ''). duration_exact($svc_acct->$uf) )
-%       ? ($svc_acct->$uf < 0 ? '-' : '').
-%         int(abs($svc_acct->$uf)/3600). "hr ".
-%         sprintf("%02d",(abs($svc_acct->$uf)%3600)/60). "min"
-%       : FS::UI::bytecount::display_bytecount($svc_acct->$uf);
-    <TR>
-      <TD ALIGN="right"><% $ulabel{$uf} %> remaining</TD>
-      <TD BGCOLOR="#ffffff"><% $v %></TD>
-    </TR>
-
-%   }
-% }
-% foreach my $attribute ( grep /^radius_/, $svc_acct->fields ) {
-%  $attribute =~ /^radius_(.*)$/;
-%  my $pattribute = $FS::raddb::attrib{$1};
-%
-
-  <TR>
-    <TD ALIGN="right">Radius (reply) <% $pattribute %></TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->getfield($attribute) %></TD>
-  </TR>
-% } 
-% foreach my $attribute ( grep /^rc_/, $svc_acct->fields ) {
-%  $attribute =~ /^rc_(.*)$/;
-%  my $pattribute = $FS::raddb::attrib{$1};
-%
-
-  <TR>
-    <TD ALIGN="right">Radius (check) <% $pattribute %></TD>
-    <TD BGCOLOR="#ffffff"><% $svc_acct->getfield($attribute) %></TD>
-  </TR>
-% } 
-
-
-<TR>
-  <TD ALIGN="right">RADIUS groups</TD>
-  <TD BGCOLOR="#ffffff"><% join('<BR>', $svc_acct->radius_groups) %></TD>
-</TR>
-%
-%# Can this be abstracted further?  Maybe a library function like
-%# widget('HTML', 'view', $svc_acct) ?  It would definitely make UI 
-%# style management easier.
-%
-% foreach (sort { $a cmp $b } $svc_acct->virtual_fields) { 
-
-  <% $svc_acct->pvf($_)->widget('HTML', 'view', $svc_acct->getfield($_)) %>
-% } 
+<% include( 'svc_acct/change_svc.html',
+              'part_svc' => \@part_svc,
+              %gopt,
+          )
+%>
 
+<% include( 'svc_acct/basics.html',
+              'svc_acct' => $svc_acct,
+              'part_svc' => $part_svc,
+              %gopt,
+          )
+%>
 
-</TABLE></TD></TR></TABLE>
 </FORM>
-<BR><BR>
+<BR>
 
-% if ( @svc_www ) {
-  Hosting
-  <% &ntable("#cccccc") %><TR><TD><% &ntable("#cccccc",2) %>
-%   foreach my $svc_www (@svc_www) {
-%     my($label, $value) = $svc_www->cust_svc->label;
-%     my $link = $p. 'view/svc_www.cgi?'. $svc_www->svcnum;
-      <TR>
-        <TD BGCOLOR="#ffffff">
-          <A HREF="<% $link %>"><% "$label: $value" %></A>
-        </TD>
-      </TR>
-%   }
-  </TABLE></TD></TR></TABLE>
-  <BR><BR>
-% }
+<% include( 'svc_acct/hosting.html',
+              %gopt,
+          )
+%>
 
+%#remove this?  does anybody even use it?  it was a misunderstood customer
+%#request IIRC?
+% my $conf = new FS::Conf;
+% if ( $conf->exists('svc_acct-notes') ) {
+%   warn 'WARNING: svc_acct-notes deprecated\n';
 <% join("<BR>", $conf->config('svc_acct-notes') ) %>
 <BR><BR>
+% }
+
+<% include('elements/svc_export_settings.html', $svc_acct) %>
 
 <% joblisting({'svcnum'=>$svcnum}, 1) %>
 
@@ -352,8 +80,6 @@
 die "access denied"
   unless $FS::CurrentUser::CurrentUser->access_right('View customer services');
 
-my $conf = new FS::Conf;
-
 my $addl_from = ' LEFT JOIN cust_svc  USING ( svcnum  ) '.
                 ' LEFT JOIN cust_pkg  USING ( pkgnum  ) '.
                 ' LEFT JOIN cust_main USING ( custnum ) ';
@@ -389,25 +115,27 @@
 die "Unknown svcpart" unless $part_svc;
 my $svc = $part_svc->svc;
 
-die 'Empty domsvc for svc_acct.svcnum '. $svc_acct->svcnum
-  unless $svc_acct->domsvc;
-my $svc_domain = qsearchs('svc_domain', { 'svcnum' => $svc_acct->domsvc } );
-die 'Unknown domain (domsvc '. $svc_acct->domsvc.
-    ' for svc_acct.svcnum '. $svc_acct->svcnum. ')'
-  unless $svc_domain;
-my $domain = $svc_domain->domain;
+my @part_svc = ();
+if ($FS::CurrentUser::CurrentUser->access_right('Change customer service')) {
 
-my @svc_www = qsearch({
-  'select'    => 'svc_www.*',
-  'table'     => 'svc_www',
-  'addl_from' => $addl_from,
-  'hashref'   => { 'usersvc' => $svcnum },
-  #XXX shit outta luck if you somehow got them linked across agents
-  # maybe we should show but not link to them?  kinda makes sense...
-  # (maybe a specific ACL for this situation???)
-  'extra_sql' => ' AND '. $FS::CurrentUser::CurrentUser->agentnums_sql(
-                            'null_right' => 'View/link unlinked services'
-                          ),
-});
+  if ( $pkgnum ) { 
+    @part_svc = grep {    $_->svcdb   eq 'svc_acct'
+                       && $_->svcpart != $part_svc->svcpart }
+                $cust_pkg->available_part_svc;
+  } else {
+    @part_svc = qsearch('part_svc', {
+      svcdb    => 'svc_acct',
+      disabled => '',
+      svcpart  => { op=>'!=', value=>$part_svc->svcpart },
+    } );
+  }
+
+}
+
+my $communigate = scalar($part_svc->part_export('communigate_pro'));
+                # || scalar($part_svc->part_export('communigate_pro_singledomain'));
+
+my %gopt = ( 'communigate' => $communigate,
+           );
 
 </%init>

Index: svc_domain.cgi
===================================================================
RCS file: /home/cvs/cvsroot/freeside/httemplate/view/svc_domain.cgi,v
retrieving revision 1.31.2.2
retrieving revision 1.31.2.3
diff -u -d -r1.31.2.2 -r1.31.2.3
--- svc_domain.cgi	17 Feb 2010 08:30:37 -0000	1.31.2.2
+++ svc_domain.cgi	20 Feb 2010 22:33:10 -0000	1.31.2.3
@@ -169,28 +169,7 @@
 % }
 <BR>
 
-% my ( $settings, $defaults ) = $svc_domain->export_getsettings;
-% if ( keys %$settings ) {
-
-%# XXX a way to label this "Communigate pro settings".. just a config maybe
-  External settings
-  <% ntable('#cccccc',2) %>
-
-%   foreach my $key ( keys %$settings ) {
-      <TR>
-        <TD ALIGN="right"><% $key |h %></TD>
-        <TD BGCOLOR="<% $defaults->{$key} ? '#eeeeee' : '#ffffff' %>">
-          <% $defaults->{$key} ? '<I>' : '<B>' %>
-          <% $settings->{$key} |h %>
-          <% $defaults->{$key} ? '</I>' : '</B>' %>
-        </TD>
-      </TR>
-%   }
-
-  </TABLE>
-  <BR>
-
-% }
+<% include('elements/svc_export_settings.html', $svc_domain) %>
 
 <% joblisting({'svcnum'=>$svcnum}, 1) %>
 



More information about the freeside-commits mailing list