[freeside-commits] freeside/FS/FS cust_attachment.pm, 1.2, 1.3 cust_main_note.pm, 1.3, 1.4

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail.420.am:/tmp/cvs-serv31361

Modified Files:
	cust_attachment.pm cust_main_note.pm 
Log Message:
fix otaker upgrade for cust_attachment & cust_main_note, hopefully

Index: cust_attachment.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/cust_attachment.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -w -d -r1.2 -r1.3
--- cust_attachment.pm	29 Mar 2010 00:23:07 -0000	1.2
+++ cust_attachment.pm	4 Apr 2010 23:18:23 -0000	1.3
@@ -128,7 +128,7 @@
     $self->ut_numbern('attachnum')
     || $self->ut_number('custnum')
     || $self->ut_numbern('_date')
-    || $self->ut_alphan('otaker')
+    || $self->ut_textn('otaker')
     || $self->ut_text('filename')
     || $self->ut_text('mime_type')
     || $self->ut_numbern('disabled')
@@ -154,6 +154,28 @@
   return length($self->body);
 }
 
+#false laziness w/otaker_Mixin & cust_main_note
+sub otaker {
+  my $self = shift;
+  if ( scalar(@_) ) { #set
+    my $otaker = shift;
+    my($l,$f) = (split(', ', $otaker));
+    my $access_user =  qsearchs('access_user', { 'username'=>$otaker }     )
+                    || qsearchs('access_user', { 'first'=>$f, 'last'=>$l } )
+      or croak "can't set otaker: $otaker not found!"; #confess?
+    $self->usernum( $access_user->usernum );
+    $otaker; #not sure return is used anywhere, but just in case
+  } else { #get
+    if ( $self->usernum ) {
+      $self->access_user->username;
+    } elsif ( length($self->get('otaker')) ) {
+      $self->get('otaker');
+    } else {
+      '';
+    }
+  }
+}
+
 # Used by FS::Upgrade to migrate to a new database.
 sub _upgrade_data {  # class method
   my ($class, %opts) = @_;

Index: cust_main_note.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/cust_main_note.pm,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -w -d -r1.3 -r1.4
--- cust_main_note.pm	4 Apr 2010 22:44:15 -0000	1.3
+++ cust_main_note.pm	4 Apr 2010 23:18:23 -0000	1.4
@@ -114,6 +114,28 @@
   $self->SUPER::check;
 }
 
+#false laziness w/otaker_Mixin & cust_attachment
+sub otaker {
+  my $self = shift;
+  if ( scalar(@_) ) { #set
+    my $otaker = shift;
+    my($l,$f) = (split(', ', $otaker));
+    my $access_user =  qsearchs('access_user', { 'username'=>$otaker }     )
+                    || qsearchs('access_user', { 'first'=>$f, 'last'=>$l } )
+      or croak "can't set otaker: $otaker not found!"; #confess?
+    $self->usernum( $access_user->usernum );
+    $otaker; #not sure return is used anywhere, but just in case
+  } else { #get
+    if ( $self->usernum ) {
+      $self->access_user->username;
+    } elsif ( length($self->get('otaker')) ) {
+      $self->get('otaker');
+    } else {
+      '';
+    }
+  }
+}
+
 # Used by FS::Upgrade to migrate to a new database.
 sub _upgrade_data {  # class method
   my ($class, %opts) = @_;