[freeside-commits] freeside/FS/FS cust_pkg.pm,1.138,1.139

[Jeff Finucane,420,,]

Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail.420.am:/tmp/cvs-serv23849

Modified Files:
	cust_pkg.pm 
Log Message:
use object copy when billing on cancel to avoid very weird side effects ( including 'impossible' history ) RT#5723

Index: cust_pkg.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/cust_pkg.pm,v
retrieving revision 1.138
retrieving revision 1.139
diff -u -d -r1.138 -r1.139
--- cust_pkg.pm	13 Aug 2009 15:13:49 -0000	1.138
+++ cust_pkg.pm	28 Sep 2009 15:55:12 -0000	1.139
@@ -603,8 +603,9 @@
   #resolved by performing a change package instead (which unprovisions) and
   #later cancelling
   if ( !$options{nobill} && !$date && $conf->exists('bill_usage_on_cancel') ) {
+      my $copy = $self->new({$self->hash});
       my $error =
-        $self->cust_main->bill( pkg_list => [ $self ], cancel => 1 );
+        $copy->cust_main->bill( pkg_list => [ $copy ], cancel => 1 );
       warn "Error billing during cancel, custnum ".
         #$self->cust_main->custnum. ": $error"
         ": $error"