[freeside-commits] freeside/FS/FS/Cron bill.pm,1.20,1.21

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS/Cron
In directory wavetail.420.am:/tmp/cvs-serv10381

Modified Files:
	bill.pm 
Log Message:
does pg try to finish the query when the job addition is committed?  well, if this works, that answers that.  RT#4412

Index: bill.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/Cron/bill.pm,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -d -r1.20 -r1.21
--- bill.pm	22 Apr 2009 20:24:52 -0000	1.20
+++ bill.pm	23 Apr 2009 04:14:54 -0000	1.21
@@ -4,6 +4,7 @@
 use vars qw( @ISA @EXPORT_OK );
 use Exporter;
 use Date::Parse;
+use DBI 1.33; #The "clone" method was added in DBI 1.33. 
 use FS::UID qw(dbh);
 use FS::Record qw(qsearchs);
 use FS::cust_main;
@@ -102,16 +103,18 @@
   warn "searching for customers:\n". join("\n", @search). "\n"
     if $opt{'v'} || $opt{'l'};
 
-  dbh->do(
-    "DECLARE cron_bill_cursor CURSOR WITH HOLD FOR ". #no WITH HOLD for mysql?
+  my $cursor_dbh = dbh->clone;
+
+  $cursor_dbh->do(
+    "DECLARE cron_bill_cursor CURSOR FOR ".
     "  SELECT custnum FROM cust_main ".
     "    WHERE ". join(' AND ', @search).
     "    ORDER BY custnum " #LIMIT 1000 "
-  ) or die dbh->errstr;
+  ) or die $cursor_dbh->errstr;
 
   while ( 1 ) {
 
-    my $sth = dbh->prepare('FETCH 1000 FROM cron_bill_cursor'); #mysql?
+    my $sth = $cursor_dbh->prepare('FETCH 100 FROM cron_bill_cursor'); #mysql?
 
     $sth->execute or die $sth->errstr;
 
@@ -156,6 +159,8 @@
 
   }
 
+  $cursor_dbh->commit or die $cursor_dbh->errstr;
+
 }
 
 1;