[freeside-commits] freeside/FS/FS/ClientAPI Signup.pm, 1.36.2.4, 1.36.2.5

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS/ClientAPI
In directory wavetail:/tmp/cvs-serv6059/FS/FS/ClientAPI

Modified Files:
      Tag: FREESIDE_1_7_BRANCH
	Signup.pm 
Log Message:
fix race condition where ->apply_payments_and_credits could double-apply in rare cases

Index: Signup.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/ClientAPI/Signup.pm,v
retrieving revision 1.36.2.4
retrieving revision 1.36.2.5
diff -u -d -r1.36.2.4 -r1.36.2.5
--- Signup.pm	1 May 2007 20:00:56 -0000	1.36.2.4
+++ Signup.pm	13 Jul 2007 23:52:31 -0000	1.36.2.5
@@ -439,7 +439,10 @@
     #warn "[fs_signup_server] error billing new customer: $bill_error"
     #  if $bill_error;
 
-    $cust_main->apply_payments_and_credits;
+    $bill_error = $cust_main->apply_payments_and_credits;
+    #warn "[fs_signup_server] error applying payments and credits for".
+    #     " new customer: $bill_error"
+    #  if $bill_error;
 
     $bill_error = $cust_main->collect('realtime' => 1);
     #warn "[fs_signup_server] error collecting from new customer: $bill_error"