[freeside-commits] freeside/FS/FS payinfo_Mixin.pm,1.4,1.5

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail:/tmp/cvs-serv20301

Modified Files:
	payinfo_Mixin.pm 
Log Message:
fix harmless warning: Use of uninitialized value in string ne at /usr/local/share/perl/5.8.4/FS/payinfo_Mixin.pm line 116

Index: payinfo_Mixin.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/payinfo_Mixin.pm,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- payinfo_Mixin.pm	28 Dec 2006 08:16:31 -0000	1.4
+++ payinfo_Mixin.pm	10 Jan 2007 08:56:07 -0000	1.5
@@ -110,21 +110,26 @@
 =cut
 
 sub paymask {
-  my($self,$paymask)=@_;
-
+  my($self, $paymask) = @_;
 
-  if ($paymask ne '') {
-    # I hate this little bit of magic...  I don't expect it to cause a problem, but who knows...
-    # If the payinfo is passed in masked then ignore it and set it based on the payinfo
-    # The only guy that should call this in this way is... $self->payinfo
+  if ( defined($paymask) && $paymask ne '' ) {
+    # I hate this little bit of magic...  I don't expect it to cause a problem,
+    # but who knows...  If the payinfo is passed in masked then ignore it and
+    # set it based on the payinfo.  The only guy that should call this in this
+    # way is... $self->payinfo
     $self->setfield('paymask', $self->mask_payinfo());
+
   } else {
+
     $paymask=$self->getfield('paymask');
     if (!defined($paymask) || $paymask eq '') {
-      # Generate it if it's blank - Note that we're not going to set it - just generate
+      # Generate it if it's blank - Note that we're not going to set it - just
+      # generate
       $paymask = $self->mask_payinfo();
     }
+
   }
+
   return $paymask;
 }