[freeside-commits] freeside/FS/FS svc_acct.pm, 1.200, 1.201 svc_Common.pm, 1.34, 1.35

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail:/tmp/cvs-serv30148/FS/FS

Modified Files:
	svc_acct.pm svc_Common.pm 
Log Message:
yow.  fix up group handling

Index: svc_Common.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/svc_Common.pm,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -d -r1.34 -r1.35
--- svc_Common.pm	6 Aug 2006 09:10:07 -0000	1.34
+++ svc_Common.pm	6 Aug 2006 20:21:32 -0000	1.35
@@ -72,7 +72,7 @@
 }
 
 #empty default
-sub _fieldhandlers { (); }
+sub _fieldhandlers { {}; }
 
 sub virtual_fields {
 
@@ -475,7 +475,7 @@
   my $self = shift;
   my $x = shift;
   my @x = ref($x) ? @$x : ($x);
-  my $coderef = scalar(@_) ? shift : {};
+  my $coderef = scalar(@_) ? shift : $self->_fieldhandlers;
 
   my $error =
     $self->ut_numbern('svcnum')

Index: svc_acct.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/svc_acct.pm,v
retrieving revision 1.200
retrieving revision 1.201
diff -u -d -r1.200 -r1.201
--- svc_acct.pm	6 Aug 2006 20:07:13 -0000	1.200
+++ svc_acct.pm	6 Aug 2006 20:21:32 -0000	1.201
@@ -192,11 +192,11 @@
   {
     #false laziness with edit/svc_acct.cgi
     'usergroup' => sub { 
-                         my $usergroup = shift;
-                         if ( ref($usergroup) eq 'ARRAY' ) {
-                           $usergroup;
-                         } elsif ( length($usergroup) ) {
-                           [ split(/\s*,\s*/, $usergroup) ];
+                         my( $self, $groups ) = @_;
+                         if ( ref($groups) eq 'ARRAY' ) {
+                           $groups;
+                         } elsif ( length($groups) ) {
+                           [ split(/\s*,\s*/, $groups) ];
                          } else {
                            [];
                          }