[bop-devel] Net::HTTPS::Any test bug / install failure, was: Business::OnlinePayment

[Stefan Hornburg (Racke)]

On 12/14/2013 12:03 AM, Ivan Kohler wrote:
> On Fri, Dec 13, 2013 at 03:38:14PM +0100, Stefan Hornburg (Racke) wrote:
>> On 02/07/2013 10:28 PM, Ivan Kohler wrote:
>>> On Thu, Feb 07, 2013 at 01:44:00PM +0100, Stefan Hornburg (Racke) wrote:
>>>>
>>>> Ivan, can you please fix the Net::HTTPS::Any bug
>>>> https://rt.cpan.org/Public/Bug/Display.html?id=73363?
>>>>
>>>> This causes install failure of Business::OnlinePayment unless you have both
>>>> SSLeay modules present.
>>>>
>>>> Please let me know if you need assistance.
>>>
>>> I certainly wouldn't refuse a patch, also happy to add you as a co-maint 
>>> for Net::HTTPS::Any
>>>
>>>
>>> For historical perspective, the whole B:OP:HTTPS / Net::HTTPS::Any thing 
>>> was mostly inspiried by Interchange's historical support for either 
>>> module and Mike Heins's reply about it being nice to have
>>> http://www.icdevgroup.org/pipermail/interchange-users/2002-September/026005.html
>>>
>>
>> Yes, please add me as co-maintainer for Net::HTTPS::Any.
> 
> Done.
> 
> FWIW, per above, the whole B:OP:HTTPS / Net::HTTPS::Any was added at 
> Interchange's behest over a decade ago.  From here in 2013, if 
> supporting both SSL modules doesn't make as much sense as it did in 
> 2002, I'm also fine with dumping the whole idea and just picking the 
> current best-practice module for B:OP.
> 

Marco Pessotto did a patch (see attachment) to replace Net::HTTPS::Any with
LWP::UserAgent and LWP::Protocol::https.

His comments:

--snip--

The code added has been ripped off from Net::HTTPS::Any (and same for
the added tests). Anyway, I modified the response header code to use a
for loop instead of the map, which was sending back odds element
(probably due to ->header() used in list context).

--snap--

Please consider this patch - so we can get rid of Net::HTTPS::Any.

Regards
	Racke


-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bop_ssl.patch
Type: text/x-patch
Size: 7512 bytes
Desc: not available
URL: <http://freeside.biz/pipermail/bop-devel/attachments/20140512/1b28f58e/attachment.bin>