[bop-devel] AuthorizeNet MD5 Check

[Bill Moseley]

On Fri, Sep 28, 2007 at 04:22:55PM -0700, Ivan Kohler wrote:
> Hi Bill,
> 
> If you'd like folks to review and possibly apply your changes to the 
> official release, I suggest you send in your changes as individual 
> patches (one for each different change) in unified format (diff -u).

As I said, I ran tidy and perl critic which modified a large number of
lines.  That's the bulk of the current diff as you can see.


> This is the usual way to contribute to an existing open-source project.

I know it's a pain to receive diff that covers the bulk of the file.
That's due to tidy and critic.  But, in this case it's not the diff
you should be looking at.

To be frank, the old code was in no shape to receive incremental
patches.  Still could use more refactoring.

Be honest, it would take you longer to review a few incremental
patches than to review this module.  This module has, what, a submit
method that is almost the same as before and two new methods I added?

> A forked version or a massive patch is unlikely to get anyone's 
> attention.

By anyone you mean Jason and you?

Look, I spent a few days and a number of hours updating this, which
includes an outstanding bug marked "Important" from 2005.  If you are
not willing to spend twenty minutes to review the code then that's up
to you.

I made the updates available to you.  Feel free to do what ever you
like with it.


-- 
Bill Moseley
moseley at hank.org