[bop-devel] AuthorizeNet MD5 Check

[Bill Moseley]

On Fri, Sep 28, 2007 at 01:05:45PM -0600, Jason Hall wrote:
> 
> I would definately suggest doing a diff -u of the different phases so that
> it can be imported back.  Several of the changes would be great, but the
> diff is the best way to do it (and explain them).

Won't help much.  I ran perltidy and perlcritic on the initial file
and didn't save that.   I have a two versions in svn, but they are not
really incremental versions.

The module is not very complex, so it's probably best to just look it
over.  If you like looking at diffs you can look at 

    http://hank.org/modules/AuthorizeNet.pm.diff1

but all the clean up will make it hard to see changes.  The functional
changes are the addition of the md5 check, and that's a separate
method.

The refactoring is a bit more too look at, and my recommendation is to
just look at the source.

    http://hank.org/modules/AuthorizeNet.pm

I could have done more but had to move on.



-- 
Bill Moseley
moseley at hank.org