[bop-devel] Re: Business-OnlinePayment/t bop.t,1.7,1.8

[Phil Lobbes]

If I do a make dist that module failes to be included in the
distribution.  I didn't investigate, but if this is supposed to be
standard we'll have to figure out why this isn't getting included.

Phil

Ivan Kohler <ivan at 420.am> wrote:

> I don't understand.  The distribution does contain 
> Business::FraudDetect::preCharge.
> 
> -- 
> _ivan
> 
> 
> On Mon, Nov 20, 2006 at 05:29:16AM +0000, Phil Lobbes wrote:
> > Update of /home/cvs/cvsroot/Business-OnlinePayment/t
> > In directory wavetail:/tmp/cvs-serv19963/t
> > 
> > Modified Files:
> > 	bop.t 
> > Log Message:
> > - removed fraud_detect w/preCharge test, dist doesn't contain preCharge yet
> > 
> > 
> > Index: bop.t
> > ===================================================================
> > RCS file: /home/cvs/cvsroot/Business-OnlinePayment/t/bop.t,v
> > retrieving revision 1.7
> > retrieving revision 1.8
> > diff -u -d -r1.7 -r1.8
> > --- bop.t	20 Nov 2006 04:54:24 -0000	1.7
> > +++ bop.t	20 Nov 2006 05:29:14 -0000	1.8
> > @@ -3,7 +3,7 @@
> >  
> >  use strict;
> >  use warnings;
> > -use Test::More tests => 62;
> > +use Test::More tests => 60;
> >  
> >  BEGIN { use_ok("Business::OnlinePayment") or exit; }
> >  
> > @@ -114,19 +114,14 @@
> >      is( $obj2->submit, "1", "MOCK3(obj2) submit returns 1" );
> >  
> >      # fraud detection failure modes
> > -    my $obj   = $package->new("MOCK3");
> > -    my $bogus = "__BOGUS_PROCESSOR";
> > -    my $valid = "preCharge";
> > +    my $obj  = $package->new("MOCK3");
> > +    my $proc = "__BOGUS_PROCESSOR";
> >  
> > -    is( $obj->fraud_detect($bogus), $bogus, "fraud_detect set to '$bogus'" );
> > +    is( $obj->fraud_detect($proc), $proc, "fraud_detect set to '$proc'" );
> >      eval { $obj->submit; };
> >      is( $@, "", "fraud_detect ignores non-existant processors" );
> >  
> > -    is( $obj->fraud_detect($valid), $valid, "fraud_detect set to '$valid'" );
> > -    eval { $obj->submit; };
> > -    like( $@, qr/^missing required /, "fraud_detect($valid) missing fields" );
> > -
> > -    # XXX: more test cases for preCharge needed
> > +    # XXX: need more test cases for when fraud detection is enabled
> >  }
> >  
> >  {    # content
> > 
> 
> _______________________________________________
> bop-devel mailing list
> bop-devel at 420.am
> http://420.am/cgi-bin/mailman/listinfo/bop-devel